Open
Conversation
… shared in a collection of strings
CheezItMan
reviewed
Sep 18, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
The first one works well, but see my notes on the time complexity. The second, longest prefix, does not, but I had to work to find an example, I ended up updating AdaGold with the example that causes yours to fail.
Overall not bad, check out my notes and let me know any questions you have.
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| require 'pry' | ||
| # Time Complexity: O(n) - as array size grows, the evaluation grows at the same rate |
There was a problem hiding this comment.
Since delete_at shifts all subsequent letters over one value to the left, and has a time complexity of O(n), your algorithm is O(n)
| k = 0 # I am the last characer that matched | ||
|
|
||
| # binding.pry | ||
| until j == max_length || i + 1 == strings.length do |
There was a problem hiding this comment.
The order you are looking at things won't work for everything, consider:
strings = ["carborator","carvonulted","carsome", "calsome"]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.